linux-kernel - Re: [PATCH] clk / soc: mediatek: fix ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34592867-0c56-8836-8ee1-b9347f34c5a6@suse.com>
Date:   Fri, 15 May 2020 13:20:50 +0200
From:   Matthias Brugger <mbrugger@...e.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, CK Hu <ck.hu@...iatek.com>,
        Stephen Boyd <sboyd@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk / soc: mediatek: fix ptr_ret.cocci warnings



On 10/05/2020 12:07, Enric Balletbo i Serra wrote:
> 
> 
> On 10/5/20 4:53, kbuild test robot wrote:
>> From: kbuild test robot <lkp@...el.com>
>>
>> drivers/soc/mediatek/mtk-mmsys.c:28:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>>
>>
>>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>>
>> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>>
>> Fixes: 13032709e232 ("clk / soc: mediatek: Move mt8173 MMSYS to platform driver")
>> CC: Matthias Brugger <mbrugger@...e.com>
>> Signed-off-by: kbuild test robot <lkp@...el.com>
> 
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> 

Since we have
667c769246b0 ("soc / drm: mediatek: Fix mediatek-drm device probing")

I think this is not a valid patch anymore.

Regards,
Matthias

>> ---
>>
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head:   30e2206e11ce27ae910cc0dab21472429e400a87
>> commit: 13032709e2328553970f0002df5edce6aac69425 [1266/7905] clk / soc: mediatek: Move mt8173 MMSYS to platform driver
>>
>>  mtk-mmsys.c |    5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> --- a/drivers/soc/mediatek/mtk-mmsys.c
>> +++ b/drivers/soc/mediatek/mtk-mmsys.c
>> @@ -25,10 +25,7 @@ static int mtk_mmsys_probe(struct platfo
>>  
>>  	clks = platform_device_register_data(&pdev->dev, data->clk_driver,
>>  					     PLATFORM_DEVID_AUTO, NULL, 0);
>> -	if (IS_ERR(clks))
>> -		return PTR_ERR(clks);
>> -
>> -	return 0;
>> +	return PTR_ERR_OR_ZERO(clks);
>>  }
>>  
>>  static const struct of_device_id of_match_mtk_mmsys[] = {
>>