lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 May 2020 09:01:33 +0800 From: Lu Baolu <baolu.lu@...ux.intel.com> To: Jacob Pan <jacob.jun.pan@...ux.intel.com>, Christoph Hellwig <hch@...radead.org> Cc: baolu.lu@...ux.intel.com, iommu@...ts.linux-foundation.org, LKML <linux-kernel@...r.kernel.org>, Joerg Roedel <joro@...tes.org>, David Woodhouse <dwmw2@...radead.org>, Jean-Philippe Brucker <jean-philippe@...aro.com>, Eric Auger <eric.auger@...hat.com>, Yi Liu <yi.l.liu@...el.com>, "Tian, Kevin" <kevin.tian@...el.com>, Raj Ashok <ashok.raj@...el.com>, Alex Williamson <alex.williamson@...hat.com>, Jonathan Cameron <jic23@...nel.org> Subject: Re: [PATCH v13 4/8] iommu/vt-d: Add bind guest PASID support Hi Jacob, On 5/14/20 11:57 PM, Jacob Pan wrote: >>> + /* >>> + * PASID table is per device for better security. >>> Therefore, for >>> + * each bind of a new device even with an existing PASID, >>> we need to >>> + * call the nested mode setup function here. >>> + */ >>> + spin_lock(&iommu->lock); >>> + ret = intel_pasid_setup_nested(iommu, >>> + dev, >>> + (pgd_t *)data->gpgd, >>> + data->hpasid, >>> + &data->vtd, >>> + dmar_domain, >>> + data->addr_width); >> Why not: >> >> et = intel_pasid_setup_nested(iommu, dev, (pgd_t *)data->gpgd, >> data->hpasid, &data->vtd, dmar_domain, >> data->addr_width); >> >> ? >> > I thought we want to align the parentheses? Either way is fine. > Baolu? > Let's keep the code style consistent in this file. Best regards, baolu
Powered by blists - more mailing lists