linux-kernel - Re: [PATCH AUTOSEL 5.6 30/62] net: Make PTP-specific drivers depend on PTP_1588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b087eec-98b8-dedf-410c-c966d9802c89@ti.com>
Date:   Fri, 15 May 2020 15:07:43 +0300
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Arnd Bergmann <arnd@...db.de>, Sasha Levin <sashal@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "# 3.4.x" <stable@...r.kernel.org>,
        Clay McClure <clay@...mons.net>,
        Richard Cochran <richardcochran@...il.com>,
        Nicolas Pitre <nico@...xnic.net>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        "David S . Miller" <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH AUTOSEL 5.6 30/62] net: Make PTP-specific drivers depend
 on PTP_1588_CLOCK



On 15/05/2020 00:40, Arnd Bergmann wrote:
> On Thu, May 14, 2020 at 8:52 PM Sasha Levin <sashal@...nel.org> wrote:
>>
>> From: Clay McClure <clay@...mons.net>
>>
>> [ Upstream commit b6d49cab44b567b3e0a5544b3d61e516a7355fad ]
>>
>> Commit d1cbfd771ce8 ("ptp_clock: Allow for it to be optional") changed
>> all PTP-capable Ethernet drivers from `select PTP_1588_CLOCK` to `imply
>> PTP_1588_CLOCK`, "in order to break the hard dependency between the PTP
>> clock subsystem and ethernet drivers capable of being clock providers."
> 
> I don't think this one should be backported unless 3a9dd3ecb207 ("kconfig:
> make 'imply' obey the direct dependency") is already backported to v5.6
> (which I don't think it should either).
> 
Yes. pls, drop it. It's rather optimization, not a fix.
And it might introduce build failures.

-- 
Best regards,
grygorii