linux-kernel - Re: [PATCH] ftrace: show debugging information when panic_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200515091513.4947ff02@gandalf.local.home>
Date:   Fri, 15 May 2020 09:15:13 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Cheng Jian <cj.chengjian@...wei.com>
Cc:     <linux-kernel@...r.kernel.org>, <xiexiuqi@...wei.com>,
        <bobo.shaobowang@...wei.com>, <huawei.libin@...wei.com>,
        <chenwandun@...wei.com>, <mingo@...hat.com>
Subject: Re: [PATCH] ftrace: show debugging information when panic_on_warn
 set

On Fri, 15 May 2020 10:08:28 +0000
Cheng Jian <cj.chengjian@...wei.com> wrote:

> When an anomaly is detected in the function call modification
> code, ftrace_bug() is called to disable function tracing as well
> as give some warn and information that may help debug the problem.
> 
> But currently, we call FTRACE_WARN_ON_ONCE() first in ftrace_bug(),
> so when panic_on_warn is set, we can't see the debugging information
> here. Call FTRACE_WARN_ON_ONCE() at the end of ftrace_bug() to ensure
> that the debugging information is displayed first.
> 
> after this patch, the dmesg looks like:
> 

Thanks, I'll add this to my queue.

-- Steve