linux-kernel - Re: [PATCH] greybus: audio: remove unused code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200515134412.GA2083757@kroah.com>
Date:   Fri, 15 May 2020 15:44:12 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Vaibhav Agarwal <vaibhav.sr@...il.com>
Cc:     Mark Greer <mgreer@...malcreek.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        linux-kernel@...r.kernel.org, greybus-dev@...ts.linaro.org,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH] greybus: audio: remove unused code

On Thu, May 14, 2020 at 01:07:36AM +0530, Vaibhav Agarwal wrote:
> On Wed, May 13, 2020 at 11:15 PM Mark Greer <mgreer@...malcreek.com> wrote:
> >
> > On Thu, May 07, 2020 at 11:29:11PM +0200, Alexandre Belloni wrote:
> > > GREYBUS_AUDIO_MSM8994 is not an existing configuration option and as
> > > reported in September 2016, it depends on an "out-of-tree qualcomm audio
> > > driver". This driver never made it upstream.
> > >
> > > https://lore.kernel.org/lkml/20160921073905.GA31263@kroah.com/
> > >
> > > Moreover, there doesn't seem to be any interest in actually fixing the
> > > driver as it uses ASoC APIs that have been removed from the kernel in 2018
> > > as shown by its use of snd_soc_register_codec and
> > > snd_soc_codec_get_drvdata, removed in commit 999f7f5af8eb ("ASoC: remove
> > > Codec related code").
> > >
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> > > ---
> Hi Alexandre,
> 
> As mentioned in the mail archive referred, the GB Codec driver that is
> currently available in kernel tree is dependent on qualcomm audio
> driver. And some time later I made some minor modifications to remove
> the unnecessary dependencies. However, I missed to share the same with
> the community :(
> 
> Thanks to you for triggering the thread. Now, I could retrieve my local
> changes and I have been in the process of updating it again to make it
> compatible with latest kernel.
> 
> I'm planning to share the same here in the next few days.  I'll mark you
> in CC to seek your review comments as well.

I'll give you a few more days for that patch to be sent before I apply
this one...

thanks,

greg k-h