lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 May 2020 10:50:36 -0300 From: Arnaldo Carvalho de Melo <arnaldo.melo@...il.com> To: Ian Rogers <irogers@...gle.com> Cc: Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...nel.org>, Mathieu Poirier <mathieu.poirier@...aro.org>, Adrian Hunter <adrian.hunter@...el.com>, Igor Lubashev <ilubashe@...mai.com>, Nick Desaulniers <ndesaulniers@...gle.com>, Alexios Zavras <alexios.zavras@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Thomas Gleixner <tglx@...utronix.de>, Wei Li <liwei391@...wei.com>, Kan Liang <kan.liang@...ux.intel.com>, Andi Kleen <ak@...ux.intel.com>, LKML <linux-kernel@...r.kernel.org>, Stephane Eranian <eranian@...gle.com> Subject: Re: [PATCH 3/3] tools/perf: build fixes for arch_errno_names.sh Em Thu, May 14, 2020 at 10:54:49AM -0700, Ian Rogers escreveu: > On Thu, May 14, 2020 at 8:04 AM Arnaldo Carvalho de Melo > <arnaldo.melo@...il.com> wrote: > > > > Em Thu, Mar 05, 2020 at 11:11:10PM -0800, Ian Rogers escreveu: > > > Allow the CC compiler to accept a CFLAGS environment variable. > > > Make the architecture test directory agree with the code comment. > > > This doesn't change the code generated but makes it easier to integrate > > > running the shell script in build systems like bazel. > > > > I've looked at this and split this part in a separate patch, and applied > > it locally, please take a look, now looking at the other bit of the > > patch. > > > This bit looks good. The CFLAGS change is something I need to deal > with a directory layout change in our build system. I added that one as well, as a separate patch, this one: commit 6e136ceba23c087b1e1b846914e425706d492a3a Author: Ian Rogers <irogers@...gle.com> Date: Thu Mar 5 23:11:10 2020 -0800 perf beauty: Allow the CC used in the arch errno names script to acccept CFLAGS Allow the CC compiler to accept a CFLAGS environment variable. This doesn't change the code generated but makes it easier to integrate running the shell script in build systems like bazel. Signed-off-by: Ian Rogers <irogers@...gle.com> Cc: Adrian Hunter <adrian.hunter@...el.com> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com> Cc: Alexios Zavras <alexios.zavras@...el.com> Cc: Andi Kleen <ak@...ux.intel.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Igor Lubashev <ilubashe@...mai.com> Cc: Jiri Olsa <jolsa@...hat.com> Cc: Kan Liang <kan.liang@...ux.intel.com> Cc: Mark Rutland <mark.rutland@....com> Cc: Mathieu Poirier <mathieu.poirier@...aro.org> Cc: Namhyung Kim <namhyung@...nel.org> Cc: Nick Desaulniers <ndesaulniers@...gle.com> Cc: Peter Zijlstra <peterz@...radead.org> Cc: Stephane Eranian <eranian@...gle.com> Cc: Thomas Gleixner <tglx@...utronix.de> Cc: Wei Li <liwei391@...wei.com> Link: http://lore.kernel.org/lkml/20200306071110.130202-4-irogers@google.com [ split from a larger patch ] Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com> diff --git a/tools/perf/trace/beauty/arch_errno_names.sh b/tools/perf/trace/beauty/arch_errno_names.sh index f8c44a85650b..9f9ea45cddc4 100755 --- a/tools/perf/trace/beauty/arch_errno_names.sh +++ b/tools/perf/trace/beauty/arch_errno_names.sh @@ -57,7 +57,7 @@ process_arch() local arch="$1" local asm_errno=$(asm_errno_file "$arch") - $gcc $include_path -E -dM -x c $asm_errno \ + $gcc $CFLAGS $include_path -E -dM -x c $asm_errno \ |grep -hE '^#define[[:blank:]]+(E[^[:blank:]]+)[[:blank:]]+([[:digit:]]+).*' \ |awk '{ print $2","$3; }' \ |sort -t, -k2 -nu \
Powered by blists - more mailing lists