| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <490d37e9-3661-ef4b-75bc-8ca7523e5bde@gmail.com>
Date: Fri, 15 May 2020 16:52:37 +0200
From: Matthias Brugger <matthias.bgg@...il.com>
To: Enric Balletbo i Serra <enric.balletbo@...labora.com>,
Wei Yongjun <weiyongjun1@...wei.com>
Cc: linux-mediatek@...ts.infradead.org,
kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH -next] soc: mediatek: Missing platform_device_unregister()
on error in mtk_mmsys_probe()
On 06/05/2020 19:24, Enric Balletbo i Serra wrote:
> Hi Wei,
>
> Thank you for your patch.
>
> On 6/5/20 16:13, Wei Yongjun wrote:
>> Add the missing platform_device_unregister() before return
>> from mtk_mmsys_probe() in the error handling case.
>>
>> Fixes: 667c769246b0 ("soc / drm: mediatek: Fix mediatek-drm device probing")
>> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
>
applied to v5.7-next/soc
Thanks!
>> ---
>> drivers/soc/mediatek/mtk-mmsys.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
>> index 05e322c9c301..05ce4cb464b0 100644
>> --- a/drivers/soc/mediatek/mtk-mmsys.c
>> +++ b/drivers/soc/mediatek/mtk-mmsys.c
>> @@ -312,8 +312,10 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
>>
>> drm = platform_device_register_data(&pdev->dev, "mediatek-drm",
>> PLATFORM_DEVID_AUTO, NULL, 0);
>> - if (IS_ERR(drm))
>> + if (IS_ERR(drm)) {
>> + platform_device_unregister(clks);
>> return PTR_ERR(drm);
>> + }
>>
>> return 0;
>> }
>>
>>
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
Powered by blists - more mailing lists