linux-kernel - Re: [PATCH] arm64: dts: mt8173: fix vcodec-enc clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 May 2020 17:28:20 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Hsin-Yi Wang <hsinyi@...omium.org>,
        linux-arm-kernel@...ts.infradead.org
Cc:     Rob Herring <robh+dt@...nel.org>,
        Yunfei Dong <yunfei.dong@...iatek.com>,
        Qianqian Yan <qianqian.yan@...iatek.com>,
        devicetree@...r.kernel.org, gtk_ruiwang <gtk_ruiwang@...iatek.com>,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: mt8173: fix vcodec-enc clock



On 04/05/2020 14:44, Hsin-Yi Wang wrote:
> Fix the assigned-clock-parents to higher frequency clock to avoid h264
> encode timeout:
> 
> [  134.763465] mtk_vpu 10020000.vpu: vpu ipi 4 ack time out !
> [  134.769008] [MTK_VCODEC][ERROR][18]: vpu_enc_send_msg() vpu_ipi_send msg_id c002 len 32 fail -5
> [  134.777707] [MTK_VCODEC][ERROR][18]: vpu_enc_encode() AP_IPIMSG_ENC_ENCODE 0 fail
> 
> venc_sel is the clock used by h264 encoder, and venclt_sel is the clock
> used by vp8 encoder. Assign venc_sel to vcodecpll_ck and venclt_sel to
> vcodecpll_370p5.
> 
>     vcodecpll                         1482000000
>        vcodecpll_ck                    494000000
>           venc_sel                     494000000
> ...
>        vcodecpll_370p5                 370500000
>           venclt_sel                   370500000
> 
> Fixes: fbbad0287cec ("arm64: dts: Using standard CCF interface to set vcodec clk")
> Signed-off-by: Hsin-Yi Wang <hsinyi@...omium.org>

Applied to v5.7-fixes

Thanks!

> ---
>  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index a212bf124e81..d0e9a2aada2e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -1422,8 +1422,8 @@ vcodec_enc: vcodec@...02000 {
>  				      "venc_lt_sel";
>  			assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>,
>  					  <&topckgen CLK_TOP_VENC_LT_SEL>;
> -			assigned-clock-parents = <&topckgen CLK_TOP_VENCPLL_D2>,
> -						 <&topckgen CLK_TOP_UNIVPLL1_D2>;
> +			assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>,
> +						 <&topckgen CLK_TOP_VCODECPLL_370P5>;
>  		};
>  
>  		jpegdec: jpegdec@...04000 {
>