linux-kernel - Re: [PATCH] ARM: dts: at91: Configure SCL gpio of i2c2 node as open drain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 May 2020 17:39:56 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
Cc:     linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, mturquette@...libre.com,
        sboyd@...nel.org, nicolas.ferre@...rochip.com,
        ludovic.desroches@...rochip.com, eugen.hristev@...rochip.com
Subject: Re: [PATCH] ARM: dts: at91: Configure SCL gpio of i2c2 node as open
 drain

On 15/05/2020 18:32:39+0300, Codrin Ciubotariu wrote:
> The SCL gpio pin of i2c2 node used for recovery needs to be configured as
> open drain.
> 
> Fixes: 455fec938bbb ("ARM: dts: at91: sama5d2: add i2c gpio pinctrl")
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> ---
>  arch/arm/boot/dts/at91-sama5d2_xplained.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Squashed in the previous one, thanks.

> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index 5846720fc9dc..851b8587068b 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -344,7 +344,7 @@ i2c2: i2c@600 {
>  					pinctrl-0 = <&pinctrl_flx0_default>;
>  					pinctrl-1 = <&pinctrl_i2c2_gpio>;
>  					sda-gpios = <&pioA PIN_PB28 GPIO_ACTIVE_HIGH>;
> -					scl-gpios = <&pioA PIN_PB29 GPIO_ACTIVE_HIGH>;
> +					scl-gpios = <&pioA PIN_PB29 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  					i2c-sda-hold-time-ns = <350>;
>  					i2c-analog-filter;
>  					i2c-digital-filter;
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com