linux-kernel - Re: [PATCH v2 15/15] mwl8k: use new module_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200516041344.GO3182@x1-fbsd>
Date:   Sat, 16 May 2020 00:13:44 -0400
From:   Rafael Aquini <aquini@...hat.com>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     jeyu@...nel.org, akpm@...ux-foundation.org, arnd@...db.de,
        rostedt@...dmis.org, mingo@...hat.com, cai@....pw,
        dyoung@...hat.com, bhe@...hat.com, peterz@...radead.org,
        tglx@...utronix.de, gpiccoli@...onical.com, pmladek@...e.com,
        tiwai@...e.de, schlad@...e.de, andriy.shevchenko@...ux.intel.com,
        keescook@...omium.org, daniel.vetter@...ll.ch, will@...nel.org,
        mchehab+samsung@...nel.org, kvalo@...eaurora.org,
        davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
        Lennert Buytenhek <buytenh@...tstofly.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Johannes Berg <johannes.berg@...el.com>,
        Ganapathi Bhat <ganapathi.bhat@....com>
Subject: Re: [PATCH v2 15/15] mwl8k: use new module_firmware_crashed()

On Fri, May 15, 2020 at 09:28:46PM +0000, Luis Chamberlain wrote:
> This makes use of the new module_firmware_crashed() to help
> annotate when firmware for device drivers crash. When firmware
> crashes devices can sometimes become unresponsive, and recovery
> sometimes requires a driver unload / reload and in the worst cases
> a reboot.
> 
> Using a taint flag allows us to annotate when this happens clearly.
> 
> Cc: linux-wireless@...r.kernel.org
> Cc: Lennert Buytenhek <buytenh@...tstofly.org>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>
> Cc: Johannes Berg <johannes.berg@...el.com>
> Cc: Ganapathi Bhat <ganapathi.bhat@....com>
> Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>
> ---
>  drivers/net/wireless/marvell/mwl8k.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c
> index 97f23f93f6e7..d609ef1bb879 100644
> --- a/drivers/net/wireless/marvell/mwl8k.c
> +++ b/drivers/net/wireless/marvell/mwl8k.c
> @@ -1551,6 +1551,7 @@ static int mwl8k_tx_wait_empty(struct ieee80211_hw *hw)
>  	 * the firmware has crashed
>  	 */
>  	if (priv->hw_restart_in_progress) {
> +		module_firmware_crashed();
>  		if (priv->hw_restart_owner == current)
>  			return 0;
>  		else
> -- 
> 2.26.2
> 
Acked-by: Rafael Aquini <aquini@...hat.com>