linux-kernel - Re: [PATCH] gpiolib: notify user-space about line status changes after flags are set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ2WGs=aWjwS=vk6-PDMvXMLppfBBF-8rs42F=ko3biNg@mail.gmail.com>
Date:   Sat, 16 May 2020 11:30:36 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Kent Gibson <warthog618@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH] gpiolib: notify user-space about line status changes
 after flags are set

On Sat, May 9, 2020 at 4:15 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:

> Since the flags can be configured in different ways depending on how the
> line is being requested - we need to call the notifier chain in different
> places separately.

Ooops.

> This comes late in the release cycle but I only recently got down to
> writing libgpiod support for this new ioctl(). When writing test cases
> I noticed this doesn't really work as expected.

This is why I am so grateful about the tests you are doing with
libgpiod! We actually find these problems quickly and not after
years. Thanks!

> This patch fixes the
> issue I identified this week. There may be more coming the following
> week though...

I will pull in your pull request once the next -rc is out as I had already
sent my first pull request, but do not hesitate to bug me about this.

Yours,
Linus Walleij