linux-kernel - Re: [PATCH v2] efi: Pull up arch-specific prototype efi_systab_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200516133758.GA19372@zn.tnic>
Date:   Sat, 16 May 2020 15:37:58 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Ard Biesheuvel <ardb@...nel.org>
Cc:     Benjamin Thiel <b.thiel@...teo.de>,
        linux-efi <linux-efi@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] efi: Pull up arch-specific prototype
 efi_systab_show_arch()

On Sat, May 16, 2020 at 03:32:25PM +0200, Ard Biesheuvel wrote:
> On Sat, 16 May 2020 at 15:26, Benjamin Thiel <b.thiel@...teo.de> wrote:
> >
> > ... in order to fix a -Wmissing-prototypes warning:
> >
> > arch/x86/platform/efi/efi.c:957:7: warning: no previous prototype for
> > ‘efi_systab_show_arch’ [-Wmissing-prototypes]
> > char *efi_systab_show_arch(char *str)
> >
> > Signed-off-by: Benjamin Thiel <b.thiel@...teo.de>
> 
> Thanks, I'll queue this as a fix.
> 
> Nit: please don't treat the subject line as the first N words of the
> commit log, but start with a full sentence. Not all mail readers show
> the subject line and the body together. I've fixed it up for now.

That was my suggestion as I do that a lot. :)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette