linux-kernel - Re: [PATCH] crypto: caam - make soc match data optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 16 May 2020 09:42:51 -0700
From:   Chris Healy <cphealy@...il.com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>
Cc:     linux-crypto@...r.kernel.org,
        Horia Geantă <horia.geanta@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Fabio Estevam <festevam@...il.com>, linux-imx@....com,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: caam - make soc match data optional

With all four of Vybrid VF610, i.MX6q, i.MX6qp, and i.MX8M, this patch
caused no regressions for me.  Additionally, with the VF610 and a
follow on devicetree patch, the CAAM is detected and works.

Tested by: Chris Healy <cphealy@...il.com>

On Fri, May 15, 2020 at 9:23 PM Andrey Smirnov <andrew.smirnov@...il.com> wrote:
>
> Vyrbrid devices don't have any clock that need to be taken care of, so
> make clock data optional on i.MX.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> Cc: Chris Healy <cphealy@...il.com>
> Cc: Horia Geantă <horia.geanta@....com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Fabio Estevam <festevam@...il.com>
> Cc: linux-imx@....com
> Cc: linux-crypto@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/crypto/caam/ctrl.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
> index 4fcdd262e581..6aba430793cc 100644
> --- a/drivers/crypto/caam/ctrl.c
> +++ b/drivers/crypto/caam/ctrl.c
> @@ -630,12 +630,7 @@ static int caam_probe(struct platform_device *pdev)
>         imx_soc_match = soc_device_match(caam_imx_soc_table);
>         caam_imx = (bool)imx_soc_match;
>
> -       if (imx_soc_match) {
> -               if (!imx_soc_match->data) {
> -                       dev_err(dev, "No clock data provided for i.MX SoC");
> -                       return -EINVAL;
> -               }
> -
> +       if (imx_soc_match && imx_soc_match->data) {
>                 ret = init_clocks(dev, imx_soc_match->data);
>                 if (ret)
>                         return ret;
> --
> 2.21.3