linux-kernel - Re: [PATCH V3 3/4] x86/resctrl: Enable per-thread MBA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2e04ff69-d246-82dd-12b9-83a1f36fccfa@intel.com>
Date:   Sat, 16 May 2020 11:03:24 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Babu Moger <babu.moger@....com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "fenghua.yu@...el.com" <fenghua.yu@...el.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "tony.luck@...el.com" <tony.luck@...el.com>
Cc:     "kuo-lang.tseng@...el.com" <kuo-lang.tseng@...el.com>,
        "ravi.v.shankar@...el.com" <ravi.v.shankar@...el.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 3/4] x86/resctrl: Enable per-thread MBA

Hi Babu,

On 5/14/2020 12:04 PM, Babu Moger wrote:
> 
> 
>> -----Original Message-----
>> From: Reinette Chatre <reinette.chatre@...el.com>
>> Sent: Wednesday, May 6, 2020 6:50 PM
>> To: tglx@...utronix.de; fenghua.yu@...el.com; bp@...en8.de;
>> tony.luck@...el.com
>> Cc: kuo-lang.tseng@...el.com; ravi.v.shankar@...el.com; mingo@...hat.com;
>> Moger, Babu <Babu.Moger@....com>; hpa@...or.com; x86@...nel.org;
>> linux-kernel@...r.kernel.org; Reinette Chatre <reinette.chatre@...el.com>
>> Subject: [PATCH V3 3/4] x86/resctrl: Enable per-thread MBA
>>
>> From: Fenghua Yu <fenghua.yu@...el.com>
>>

...

>>  static int rdt_thread_throttle_mode_show(struct kernfs_open_file *of,
>>  					 struct seq_file *seq, void *v)
>>  {
>>  	unsigned int throttle_mode = 0;
>>
>> +	if (boot_cpu_has(X86_FEATURE_PER_THREAD_MBA)) {
>> +		seq_puts(seq, "per-thread\n");
>> +
> You probably don't need an extra line here.
> 

This area looks slightly different after moving to a resource property
but unnecessary extra lines will be removed.

Thank you very much

Reinette