linux-kernel - Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9b02abcd-23a0-8edb-674a-44358a516015@codeaurora.org>
Date:   Sat, 16 May 2020 23:44:32 +0530
From:   Ajit Pandey <ajitp@...eaurora.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     plai@...eaurora.org, bgoswami@...eaurora.org,
        srinivas.kandagatla@...aro.org, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass
 bindings header

On 5/14/2020 10:18 PM, Mark Brown wrote:
> On Thu, May 14, 2020 at 10:08:16PM +0530, Ajit Pandey wrote:
>
>> +#define MI2S_PRIMARY	0
>> +#define MI2S_SECONDARY	1
>> +
>> +#define LPASS_MCLK0	0
> These look like they could use namespacing.  Is primary/secondary
> perhaps something that could be a boolean property?

Primary/secondary is a dai id and can be from 0-4 (SC7180 soc driver 
support only 0-1 at present). Such id is mainly used in dtsi and machine 
driver to do dai id based configuration for a soc hence we placed them 
in dt headers file for now.