lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 May 2020 19:02:20 -0700 From: Bart Van Assche <bvanassche@....org> To: Avri Altman <avri.altman@....com>, "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>, "Martin K . Petersen" <martin.petersen@...cle.com>, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org Cc: alim.akhtar@...sung.com, asutoshd@...eaurora.org, Zang Leigang <zangleigang@...ilicon.com>, Avi Shchislowski <avi.shchislowski@....com>, Bean Huo <beanhuo@...ron.com>, cang@...eaurora.org, stanley.chu@...iatek.com, MOHAMMED RAFIQ KAMAL BASHA <md.rafiq@...sung.com>, Sang-yoon Oh <sangyoon.oh@...sung.com>, yongmyung lee <ymhungry.lee@...sung.com>, Jinyoung CHOI <j-young.choi@...sung.com> Subject: Re: [RFC PATCH 05/13] scsi: ufs: ufshpb: Disable HPB if no HPB-enabled luns On 2020-05-15 03:30, Avri Altman wrote: > @@ -368,6 +390,8 @@ int ufshpb_probe(struct ufs_hba *hba) > if (ret) > goto out; > > + INIT_DELAYED_WORK(&hba->hpb_disable_work, ufshpb_disable_work); > + schedule_delayed_work(&hba->hpb_disable_work, 60 * HZ); > out: > kfree(dev_desc); > if (ret) { Calling INIT_DELAYED_WORK() just before schedule_delayed_work() is a bad practice. If cancel_delayed_work() gets called before INIT_DELAYED_WORK() then it will encounter something that it not expects. If cancel_delayed_work() and INIT_DELAYED_WORK() get called concurrently than that will trigger a race condition. It is better to call INIT_DELAYED_WORK() from the context that allocates the data structure in which the work structure is embedded. Thanks, Bart.
Powered by blists - more mailing lists