linux-kernel - Re: [PATCH] csky: Fixup calltrace panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200517175220.GA48379@roeck-us.net>
Date:   Sun, 17 May 2020 10:52:20 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Guo Ren <guoren@...ux.alibaba.com>
Cc:     linux-csky@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] csky: Fixup calltrace panic

Hi,

On Wed, May 13, 2020 at 03:15:25PM +0800, Guo Ren wrote:
> The implementation of show_stack will panic with wrong fp:
> 
> addr    = *fp++;
> 
> because the fp isn't checked properly.
> 
> The current implementations of show_stack, wchan and stack_trace
> haven't been designed properly, so just deprecate them.
> 
> This patch is a reference to riscv's way, all codes are modified from
> arm's. The patch is passed with:
> 
>  - cat /proc/<pid>/stack
>  - cat /proc/<pid>/wchan
>  - echo c > /proc/sysrq-trigger
> 
> Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>

This patch results in:

gcc version: csky-linux-gcc (GCC) 9.3.0

Building csky:defconfig ... failed
--------------
Error log:
csky-linux-gcc: error: unrecognized command line option '-mbacktrace'; did you mean '-fbacktrace'?
csky-linux-gcc: error: unrecognized command line option '-mbacktrace'; did you mean '-fbacktrace'?
make[2]: *** [scripts/mod/devicetable-offsets.s] Error 1
make[2]: *** Waiting for unfinished jobs....
csky-linux-gcc: error: unrecognized command line option '-mbacktrace'; did you mean '-fbacktrace'?
make[2]: *** [scripts/mod/empty.o] Error 1
make[1]: *** [prepare0] Error 2
make: *** [sub-make] Error 2

when trying to build csky images with upstream gcc 9.3.0.

What version of gcc is needed to build csky images ? Also, would it be
possible to support the upstream version of gcc ?

Thanks,
Guenter