linux-kernel - Re: [PATCH] rds: convert get_user_pages() --> pin_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200517.123806.1659008654334663086.davem@davemloft.net>
Date:   Sun, 17 May 2020 12:38:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jhubbard@...dia.com
Cc:     linux-kernel@...r.kernel.org, kuba@...nel.org,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        rds-devel@....oracle.com
Subject: Re: [PATCH] rds: convert get_user_pages() --> pin_user_pages()

From: John Hubbard <jhubbard@...dia.com>
Date: Sat, 16 May 2020 18:23:36 -0700

> This code was using get_user_pages_fast(), in a "Case 2" scenario
> (DMA/RDMA), using the categorization from [1]. That means that it's
> time to convert the get_user_pages_fast() + put_page() calls to
> pin_user_pages_fast() + unpin_user_pages() calls.
> 
> There is some helpful background in [2]: basically, this is a small
> part of fixing a long-standing disconnect between pinning pages, and
> file systems' use of those pages.
> 
> [1] Documentation/core-api/pin_user_pages.rst
> 
> [2] "Explicit pinning of user-space pages":
>     https://lwn.net/Articles/807108/
> 
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: netdev@...r.kernel.org
> Cc: linux-rdma@...r.kernel.org
> Cc: rds-devel@....oracle.com
> Signed-off-by: John Hubbard <jhubbard@...dia.com>

Applied to net-next, thanks.