lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 May 2020 23:36:57 +0100 From: David Howells <dhowells@...hat.com> To: Matthew Wilcox <willy@...radead.org> Cc: dhowells@...hat.com, torvalds@...ux-foundation.org, linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] afs: Don't unlock fetched data pages until the op completes successfully Matthew Wilcox <willy@...radead.org> wrote: > > + if (req->page_done) > > + for (req->index = 0; req->index < req->nr_pages; req->index++) > > + req->page_done(req); > > + > > I'd suggest doing one call rather than N and putting the page iteration > inside the callback. But this patch is appropriate for this late in > the -rc series, just something to consider for the future. My rewrite of the fscache stuff changes this bit of the code anyway, and makes it one call which may start a write out to the cache. David
Powered by blists - more mailing lists