linux-kernel - Re: [PATCH v2 3/4] hung_task: Move hung_task sysctl interface to hung

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202005161942.682497BF@keescook>
Date:   Sat, 16 May 2020 19:43:15 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Xiaoming Ni <nixiaoming@...wei.com>
Cc:     mcgrof@...nel.org, yzaikin@...gle.com, adobriyan@...il.com,
        peterz@...radead.org, mingo@...nel.org, patrick.bellasi@....com,
        gregkh@...uxfoundation.org, tglx@...utronix.de,
        Jisheng.Zhang@...aptics.com, bigeasy@...utronix.de,
        pmladek@...e.com, ebiederm@...ssion.com,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        wangle6@...wei.com
Subject: Re: [PATCH v2 3/4] hung_task: Move hung_task sysctl interface to
 hung_task.c

On Sat, May 16, 2020 at 04:55:14PM +0800, Xiaoming Ni wrote:
> +/*
> + * This is needed for proc_doulongvec_minmax of sysctl_hung_task_timeout_secs
> + * and hung_task_check_interval_secs
> + */
> +static unsigned long hung_task_timeout_max = (LONG_MAX / HZ);

Please make this const. With that done, yes, looks great!

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook