linux-kernel - Re: [PATCH v2 3/4] hung_task: Move hung_task sysctl interface to hung

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 17 May 2020 11:01:51 +0800
From:   Xiaoming Ni <nixiaoming@...wei.com>
To:     Kees Cook <keescook@...omium.org>
CC:     <mcgrof@...nel.org>, <yzaikin@...gle.com>, <adobriyan@...il.com>,
        <peterz@...radead.org>, <mingo@...nel.org>,
        <patrick.bellasi@....com>, <gregkh@...uxfoundation.org>,
        <tglx@...utronix.de>, <Jisheng.Zhang@...aptics.com>,
        <bigeasy@...utronix.de>, <pmladek@...e.com>,
        <ebiederm@...ssion.com>, <linux-kernel@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>, <wangle6@...wei.com>,
        <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2 3/4] hung_task: Move hung_task sysctl interface to
 hung_task.c

On 2020/5/17 10:43, Kees Cook wrote:
> On Sat, May 16, 2020 at 04:55:14PM +0800, Xiaoming Ni wrote:
>> +/*
>> + * This is needed for proc_doulongvec_minmax of sysctl_hung_task_timeout_secs
>> + * and hung_task_check_interval_secs
>> + */
>> +static unsigned long hung_task_timeout_max = (LONG_MAX / HZ);
> 
> Please make this const. With that done, yes, looks great!
> 
> Reviewed-by: Kees Cook <keescook@...omium.org>
> 

Thank you for your guidance, I will fix it in v3

In addition, I am a bit confused about the patch submission, and hope to 
get everyone's answer.
   I made this patch based on the master branch. But as in conflict at 
https://lkml.org/lkml/2020/5/10/413, my patch will inevitably conflict. 
Should I modify to make patch based on "linux-next" branch to avoid 
conflict, or other branches?

Thanks
Xiaoming Ni