linux-kernel - Re: [PATCH] tracing: do not create option file latency-format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 17 May 2020 09:34:52 +0000
From:   Changbin Du <changbin.du@...il.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Changbin Du <changbin.du@...il.com>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: do not create option file latency-format

Hi Steven,

On Sat, May 16, 2020 at 01:15:21PM -0400, Steven Rostedt wrote:
> On Sun, 17 May 2020 00:10:17 +0800
> Changbin Du <changbin.du@...il.com> wrote:
> 
> > The flag LATENCY_FMT actually is usually set by latency tracers internally.
> > So I think we should not export it to userspace. This patch removes the
> > option file 'latency-format' but keep the flag defined as usual.
> > 
> > Signed-off-by: Changbin Du <changbin.du@...il.com>
> > ---
> 
> Sorry, I actually do sometimes use that option for things other than
> latency tracers. So NACK.
>
May I know which tracer use this option as well? As far as I know,
besides latency tracers, the fgraph tracer also uses it.

I think 'irq-info' and 'latency-format' is somewhat overlaps. So
my thought is:
 1) function and function graph tracers should use irq-info.
 2) latency tracers should set latency-format.

I am not quite sure whether this is a good idea. :)

> -- Steve

-- 
Cheers,
Changbin Du