linux-kernel - Re: [PATCH] clk/ti/adpll: Add a NULL check for devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202005181209.3eOwMuS3%lkp@intel.com>
Date:   Mon, 18 May 2020 13:02:10 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Xu Wang <vulab@...as.ac.cn>, t-kristo@...com,
        mturquette@...libre.com, sboyd@...nel.org,
        linux-omap@...r.kernel.org, linux-clk@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk/ti/adpll: Add a NULL check for devm_kasprintf()

Hi Xu,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on v5.7-rc6 next-20200515]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Xu-Wang/clk-ti-adpll-Add-a-NULL-check-for-devm_kasprintf/20200518-114748
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: i386-allyesconfig (attached as .config)
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-193-gb8fad4bc-dirty
        # save the attached .config to linux build tree
        make C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/clk/ti/adpll.c:200:32: sparse: sparse: incorrect type in return expression (different base types) @@    expected char const * @@    got t * @@
>> drivers/clk/ti/adpll.c:200:32: sparse:    expected char const *
>> drivers/clk/ti/adpll.c:200:32: sparse:    got int

vim +200 drivers/clk/ti/adpll.c

   181	
   182	static const char *ti_adpll_clk_get_name(struct ti_adpll_data *d,
   183						 int output_index,
   184						 const char *postfix)
   185	{
   186		const char *name;
   187		int err;
   188	
   189		if (output_index >= 0) {
   190			err = of_property_read_string_index(d->np,
   191							    "clock-output-names",
   192							    output_index,
   193							    &name);
   194			if (err)
   195				return NULL;
   196		} else {
   197			name = devm_kasprintf(d->dev, GFP_KERNEL, "%08lx.adpll.%s",
   198					      d->pa, postfix);
   199			if (!name)
 > 200				return -ENOMEM;
   201		}
   202	
   203		return name;
   204	}
   205	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (72516 bytes)