lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 May 2020 22:23:59 +0200 From: Daniel Lezcano <daniel.lezcano@...aro.org> To: Kefeng Wang <wangkefeng.wang@...wei.com>, Palmer Dabbelt <palmer@...belt.com>, tglx@...utronix.de Cc: Paul Walmsley <paul.walmsley@...ive.com>, aou@...s.berkeley.edu, linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org, hulkci@...wei.com Subject: Re: [PATCH 09/10] timer-riscv: Fix undefined riscv_time_val Hi Kefeng, On 18/05/2020 17:40, Kefeng Wang wrote: > > On 2020/5/18 22:09, Daniel Lezcano wrote: >> On 13/05/2020 23:14, Palmer Dabbelt wrote: >>> On Sun, 10 May 2020 19:20:00 PDT (-0700), wangkefeng.wang@...wei.com >>> wrote: >>>> ERROR: modpost: "riscv_time_val" [crypto/tcrypt.ko] undefined! >>>> >>>> Reported-by: Hulk Robot <hulkci@...wei.com> >>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com> >>>> --- >>>> drivers/clocksource/timer-riscv.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/clocksource/timer-riscv.c >>>> b/drivers/clocksource/timer-riscv.c >>>> index c4f15c4068c0..071b8c144027 100644 >>>> --- a/drivers/clocksource/timer-riscv.c >>>> +++ b/drivers/clocksource/timer-riscv.c >>>> @@ -19,6 +19,7 @@ >>>> >>>> u64 __iomem *riscv_time_cmp; >>>> u64 __iomem *riscv_time_val; >>>> +EXPORT_SYMBOL(riscv_time_val); >>>> >>>> static inline void mmio_set_timer(u64 val) >>>> { >>> Reviewed-by: Palmer Dabbelt <palmerdabbelt@...gle.com> >>> Acked-by: Palmer Dabbelt <palmerdabbelt@...gle.com> >>> >>> Adding the clocksource maintainers. Let me know if you want this >>> through my >>> tree, I'm assuming you want it through your tree. >> How can we end up by an export symbol here ?! > > Hi Danile, s/Danile/Daniel/ > Found this build error when CONFIG_RISCV_M_MODE=y and CONFIG_RISCV_SBI > is not, > > see patch "4f9bbcefa142 riscv: add support for MMIO access to the timer > registers" Thanks for the pointer. The question still remains, how do we end up with this EXPORT_SYMBOL? There is something wrong if the fix is an EXPORT_SYMBOL for a global variable. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Powered by blists - more mailing lists