linux-kernel - Re: [PATCH v2 3/7] dt-bindings: watchdog: dw-wdt: Add watchdog TOPs array property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200518214200.cmkzyzzwxm4kotte@mobilestation>
Date:   Tue, 19 May 2020 00:42:00 +0300
From:   Serge Semin <Sergey.Semin@...kalelectronics.ru>
To:     Rob Herring <robh@...nel.org>
CC:     Serge Semin <fancer.lancer@...il.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Paul Burton <paulburton@...nel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Arnd Bergmann <arnd@...db.de>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        <linux-mips@...r.kernel.org>, <linux-watchdog@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/7] dt-bindings: watchdog: dw-wdt: Add watchdog TOPs
 array property

On Mon, May 18, 2020 at 02:40:37PM -0600, Rob Herring wrote:
> On Sun, May 10, 2020 at 01:58:03PM +0300, Serge Semin wrote:
> > In case if DW Watchdog IP core is built with WDT_USE_FIX_TOP == false,
> > a custom timeout periods are used to preset the timer counter. In
> > this case that periods should be specified in a new "snps,watchdog-tops"
> > property of the DW watchdog dts node.
> > 
> > Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> > Cc: Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>
> > Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> > Cc: Paul Burton <paulburton@...nel.org>
> > Cc: Ralf Baechle <ralf@...ux-mips.org>
> > Cc: Arnd Bergmann <arnd@...db.de>
> > Cc: Philipp Zabel <p.zabel@...gutronix.de>
> > Cc: linux-mips@...r.kernel.org
> > 
> > ---
> > 
> > Rob, I had to remove your Reviewed-by tag, since the patch needed
> > to be updated a bit (see changelog).
> > 
> > Changelog v2:
> > - Rearrange SoBs.
> > - Move $ref to the root level of the "snps,watchdog-tops" property
> >   so does the constraints.
> > - Add default TOP values array.
> > - Discard the label definition from the new bindings example.
> > ---
> >  .../bindings/watchdog/snps,dw-wdt.yaml        | 33 +++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > index 5bf6dc6377f3..cc741fb5a685 100644
> > --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > @@ -39,6 +39,24 @@ properties:
> >      description: Phandle to the DW Watchdog reset lane
> >      maxItems: 1
> >  
> > +  snps,watchdog-tops:
> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> > +    description: |
> > +      DW APB Watchdog custom timer intervals - Timeout Period ranges (TOPs).
> > +      Each TOP is a number loaded into the watchdog counter at the moment of
> > +      the timer restart. The counter decrementing happens each tick of the
> > +      reference clock. Therefore the TOPs array is equivalent to an array of
> > +      the timer expiration intervals supported by the DW APB Watchdog. Note
> > +      DW APB Watchdog IP-core might be synthesized with fixed TOP values,
> > +      in which case this property is unnecessary with default TOPs utilized.
> > +    default: [0x0001000 0x0002000 0x0004000 0x0008000
> > +      0x0010000 0x0020000 0x0040000 0x0080000
> > +      0x0100000 0x0200000 0x0400000 0x0800000
> > +      0x1000000 0x2000000 0x4000000 0x8000000]
> > +    items:
> > +      minItems: 16
> > +      maxItems: 16
> 
> Drop 'items' and move these up a level. That may have given you some 
> issues, but I made some fixes recently.

Ok. Thanks.

-Sergey

> 
> With that,
> 
> Reviewed-by: Rob Herring <robh@...nel.org>
> 
> Rob