linux-kernel - Re: [RFC PATCH v2 1/3] cpufreq: handle the return value of '.set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200518074619.yznopcgqmoq6ds7t@vireshk-i7>
Date:   Mon, 18 May 2020 13:16:19 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Xiongfeng Wang <wangxiongfeng2@...wei.com>
Cc:     rjw@...ysocki.net, Souvik.Chakravarty@....com,
        Thanu.Rangarajan@....com, Sudeep.Holla@....com,
        guohanjun@...wei.com, john.garry@...wei.com,
        jonathan.cameron@...wei.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2 1/3] cpufreq: handle the return value of
 '.set_boost()' properly

On 18-05-20, 15:10, Xiongfeng Wang wrote:
> 'freq_qos_update_request()' called by 'cpufreq_boost_set_sw()' reutrns 1
> when the effective constraint value of frequency QoS has changed. It's
> not an error code. So handle the return value 1 of '.set_boost()' in
> 'cpufreq_boost_trigger_state()' properly.
> 
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@...wei.com>
> ---
>  drivers/cpufreq/cpufreq.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 4adac3a..bb6746e 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -2540,7 +2540,10 @@ int cpufreq_boost_trigger_state(int state)
>  	write_unlock_irqrestore(&cpufreq_driver_lock, flags);
>  
>  	ret = cpufreq_driver->set_boost(state);
> -	if (ret) {
> +	if (ret == 1) {
> +		pr_debug("The effective constraint value of frequency QoS has changed.\n");
> +		return 0;
> +	} else if (ret) {

Rafael, IMO it is better to pick patch from Sergey for this as this is
implementation detail.

>  		write_lock_irqsave(&cpufreq_driver_lock, flags);
>  		cpufreq_driver->boost_enabled = !state;
>  		write_unlock_irqrestore(&cpufreq_driver_lock, flags);
> -- 
> 1.7.12.4

-- 
viresh