linux-kernel - Re: [PATCH 2/2] mfd: mfd_cell: constify platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 May 2020 09:45:25 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     kbuild test robot <lkp@...el.com>
Cc:     Tomas Winkler <tomas.winkler@...el.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mfd: mfd_cell: constify platform_data

On Sat, 16 May 2020, kbuild test robot wrote:

> Hi Tomas,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on ljones-mfd/for-mfd-next]
> [also build test ERROR on v5.7-rc5 next-20200515]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> 
> url:    https://github.com/0day-ci/linux/commits/Tomas-Winkler/mfd-constify-pointers/20200516-190733
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
> config: arm-randconfig-r006-20200515 (attached as .config)
> compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 13d44b2a0c7ef404b13b16644765977cd5310fe2)
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install arm cross compiling tool for clang build
>         # apt-get install binutils-arm-linux-gnueabi
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>, old ones prefixed by <<):
> 
> >> drivers/hid/hid-sensor-hub.c:738:33: error: initializing 'struct hid_sensor_hub_device *' with an expression of type 'const void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> struct hid_sensor_hub_device *hsdev =
> ^

Obviously this would need fixing before it can be considered.

> 1 error generated.
> 
> vim +738 drivers/hid/hid-sensor-hub.c
> 
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  726  
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  727  static void sensor_hub_remove(struct hid_device *hdev)
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  728  {
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  729  	struct sensor_hub_data *data = hid_get_drvdata(hdev);
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  730  	unsigned long flags;
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19  731  	int i;
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  732  
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  733  	hid_dbg(hdev, " hardware removed\n");
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  734  	hid_hw_close(hdev);
> f2f13a68c37c13a Axel Lin            2012-09-19  735  	hid_hw_stop(hdev);
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  736  	spin_lock_irqsave(&data->lock, flags);
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19  737  	for (i = 0; i < data->hid_sensor_client_cnt; ++i) {
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19 @738  		struct hid_sensor_hub_device *hsdev =
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19  739  			data->hid_sensor_hub_client_devs[i].platform_data;
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19  740  		if (hsdev->pending.status)
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19  741  			complete(&hsdev->pending.ready);
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19  742  	}
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  743  	spin_unlock_irqrestore(&data->lock, flags);
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  744  	mfd_remove_devices(&hdev->dev);
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  745  	mutex_destroy(&data->mutex);
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  746  }
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05  747  
> 
> :::::: The code at line 738 was first introduced by commit
> :::::: e651a1da442ae02a50081e38309dea5e89da2d41 HID: hid-sensor-hub: Allow parallel synchronous reads
> 
> :::::: TO: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> :::::: CC: Jiri Kosina <jkosina@...e.cz>
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org



-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog