linux-kernel - Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <e8859fcf-fc00-01fc-b64e-dba086c8155b@linaro.org>
Date:   Mon, 18 May 2020 10:22:50 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Ajit Pandey <ajitp@...eaurora.org>, broonie@...nel.org,
        plai@...eaurora.org, bgoswami@...eaurora.org
Cc:     alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass
 bindings header



On 14/05/2020 17:38, Ajit Pandey wrote:
> Add header defining dai-id and mclk id for SC7180 lpass soc.
> 
> Signed-off-by: Ajit Pandey <ajitp@...eaurora.org>
> ---
>   include/dt-bindings/sound/sc7180-lpass.h | 10 ++++++++++

Why not reuse or rename include/dt-bindings/sound/apq8016-lpass.h to 
include/dt-bindings/sound/lpass.h and reuse across all the LPASS variants?

--srini

>   1 file changed, 10 insertions(+)
>   create mode 100644 include/dt-bindings/sound/sc7180-lpass.h
> 
> diff --git a/include/dt-bindings/sound/sc7180-lpass.h b/include/dt-bindings/sound/sc7180-lpass.h
> new file mode 100644
> index 0000000..7d988f6
> --- /dev/null
> +++ b/include/dt-bindings/sound/sc7180-lpass.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __DT_SC7180_LPASS_H
> +#define __DT_SC7180_LPASS_H
> +
> +#define MI2S_PRIMARY	0
> +#define MI2S_SECONDARY	1
> +
> +#define LPASS_MCLK0	0
> +
> +#endif /* __DT_APQ8016_LPASS_H */
>