lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 May 2020 14:18:22 +0300 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Serge Semin <Sergey.Semin@...kalelectronics.ru> Cc: Serge Semin <fancer.lancer@...il.com>, Mark Brown <broonie@...nel.org>, Georgy Vlasov <Georgy.Vlasov@...kalelectronics.ru>, Ramil Zaripov <Ramil.Zaripov@...kalelectronics.ru>, Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Paul Burton <paulburton@...nel.org>, Ralf Baechle <ralf@...ux-mips.org>, Arnd Bergmann <arnd@...db.de>, Allison Randal <allison@...utok.net>, Gareth Williams <gareth.williams.jx@...esas.com>, Rob Herring <robh+dt@...nel.org>, linux-mips@...r.kernel.org, devicetree@...r.kernel.org, Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@...el.com>, Charles Keepax <ckeepax@...nsource.cirrus.com>, Clement Leger <cleger@...ray.eu>, "wuxu.wu" <wuxu.wu@...wei.com>, Phil Edworthy <phil.edworthy@...esas.com>, Thomas Gleixner <tglx@...utronix.de>, Jarkko Nikula <jarkko.nikula@...ux.intel.com>, linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 18/19] spi: dw: Use regset32 DebugFS method to create regdump file On Sat, May 16, 2020 at 11:46:34PM +0300, Serge Semin wrote: > On Fri, May 15, 2020 at 06:10:56PM +0300, Andy Shevchenko wrote: > > On Fri, May 15, 2020 at 01:47:57PM +0300, Serge Semin wrote: > > > DebugFS kernel interface provides a dedicated method to create the > > > registers dump file. Use it instead of creating a generic DebugFS > > > file with manually written read callback function. > > With below nit addressed, > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> > > > +#define DW_SPI_DBGFS_REG(_name, _off) \ > > > +{ \ > > > + .name = _name, \ > > > > > + .offset = _off \ > > > > As previously discussed (did I miss your answer?) the comma at the end leaves > > better pattern for maintenance prospective. > > Ah, sorry. Missed that. This comma is hardly needed seeing the structure > consists of just two elements. So I'd rather leave it as is. While it's a really small thing, I consider that it's not good to make someone's else problem what can be done here. So, please, consider to add a comma. Look at the other drivers and code in the kernel. This is at least defacto preferred style. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists