lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 May 2020 20:36:06 +0800 From: Wu Bo <wubo40@...wei.com> To: <tj@...nel.org>, <axboe@...nel.dk> CC: <cgroups@...r.kernel.org>, <linux-block@...r.kernel.org>, <Markus.Elfring@....de>, <linux-kernel@...r.kernel.org>, <liuzhiqiang26@...wei.com>, <linfeilong@...wei.com>, <wubo40@...wei.com> Subject: [PATCH] blkcg:Fix memory leaks in blkg_conf_prep() From: Wu Bo <wubo40@...wei.com> If a call of the function blkg_lookup_check() failed, we should be release the previously allocated block group before jumping to the lable 'fail_unlock' in the implementation of the function blkg_conf_prep(). Suggested-by: Markus Elfring <Markus.Elfring@....de> Signed-off-by: Wu Bo <wubo40@...wei.com> --- V2: omit the source code quotation from the change description --- block/blk-cgroup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 930212c..afeb769 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -682,6 +682,7 @@ int blkg_conf_prep(struct blkcg *blkcg, const struct blkcg_policy *pol, blkg = blkg_lookup_check(pos, pol, q); if (IS_ERR(blkg)) { ret = PTR_ERR(blkg); + blkg_free(new_blkg); goto fail_unlock; } -- 1.8.3.1
Powered by blists - more mailing lists