linux-kernel - Re: [PATCH] arm: dts: am33xx-bone-common: add gpio-line-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zha5whf4.fsf@kernel.org>
Date:   Mon, 18 May 2020 15:34:23 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Drew Fustini <drew@...gleboard.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        Rob Herring <robh+dt@...nel.org>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        "open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        Jason Kridner <jkridner@...gleboard.org>,
        Robert Nelson <robertcnelson@...gleboard.org>
Subject: Re: [PATCH] arm: dts: am33xx-bone-common: add gpio-line-names

Linus Walleij <linus.walleij@...aro.org> writes:

> On Mon, May 18, 2020 at 10:18 AM Felipe Balbi <balbi@...nel.org> wrote:
>> Linus Walleij <linus.walleij@...aro.org> writes:
>> >> gpiochip0 - 32 lines:
>> >>         line   0:   "ethernet"       unused   input  active-high
>> >>         line   1:   "ethernet"       unused   input  active-high
>> >
>> > Why are the ethernet lines not tagged with respective signal name
>> > when right below the SPI lines are explicitly tagged with
>> > sclk, cs0 etc?
>> >
>> > Ethernet is usually RGMII and has signal names like
>> > tx_clk, tx_d0, tx_en etc.
>> >
>> > Also some lines seem to be tagged with the pin number
>> > like P9_22, P2_21 below, it seems a bit inconsistent
>> > to have much information on some pins and very sketchy
>> > information on some.
>>
>> the pin names match the beagle bone documentation and would help users
>> figure out which pins on the expansion headers match to a gpio signal.
>
> OK if it is how it looks in the documentation I agree that is what
> users need, maybe the documentation is confusing but there is not
> much to do about that.

the board has two expansion headers, P1 and P2:

https://github.com/beagleboard/pocketbeagle/wiki/System-Reference-Manual#531_Expansion_Headers

Pins are always the pin number on the header, hence P2_21 and P1_10 and
so on.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)