linux-kernel - Re: [PATCH] KVM: Fix the indentation to match coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 May 2020 11:00:52 +0800
From:   Wanpeng Li <kernellwp@...il.com>
To:     Haiwei Li <lihaiwei.kernel@...il.com>
Cc:     "pbonzini@...hat.com" <pbonzini@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>,
        "x86@...nel.org" <x86@...nel.org>, kvm <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KVM: Fix the indentation to match coding style

On Mon, 18 May 2020 at 09:32, Haiwei Li <lihaiwei.kernel@...il.com> wrote:
>
> From: Haiwei Li <lihaiwei@...cent.com>
>
> There is a bad indentation in next&queue branch. The patch looks like
> fixes nothing though it fixes the indentation.
>
> Before fixing:
>
>                  if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                          kvm_skip_emulated_instruction(vcpu);
>                          ret = EXIT_FASTPATH_EXIT_HANDLED;
>                 }
>                  break;
>          case MSR_IA32_TSCDEADLINE:
>
> After fixing:
>
>                  if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                          kvm_skip_emulated_instruction(vcpu);
>                          ret = EXIT_FASTPATH_EXIT_HANDLED;
>                  }
>                  break;
>          case MSR_IA32_TSCDEADLINE:
>

Reviewed-by: Wanpeng Li <wanpengli@...cent.com>

>
> Signed-off-by: Haiwei Li <lihaiwei@...cent.com>
> ---
>   arch/x86/kvm/x86.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 471fccf..446f747 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1631,7 +1631,7 @@ fastpath_t handle_fastpath_set_msr_irqoff(struct
> kvm_vcpu *vcpu)
>                  if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                          kvm_skip_emulated_instruction(vcpu);
>                          ret = EXIT_FASTPATH_EXIT_HANDLED;
> -               }
> +               }
>                  break;
>          case MSR_IA32_TSCDEADLINE:
>                  data = kvm_read_edx_eax(vcpu);
> --
> 1.8.3.1