linux-kernel - Re: [RESEND PATCH v8 0/3] Add Intel ComboPhy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d58e6e6-4860-dbde-1b9e-e0804180cddb@ti.com>
Date:   Mon, 18 May 2020 19:19:32 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Dilip Kota <eswara.kota@...ux.intel.com>,
        <linux-kernel@...r.kernel.org>, <vkoul@...nel.org>,
        <devicetree@...r.kernel.org>
CC:     <robh@...nel.org>, <andriy.shevchenko@...el.com>,
        <cheol.yong.kim@...el.com>, <chuanhua.lei@...ux.intel.com>,
        <qi-ming.wu@...el.com>, <yixin.zhu@...el.com>
Subject: Re: [RESEND PATCH v8 0/3] Add Intel ComboPhy driver

Dilip,

On 5/15/2020 1:43 PM, Dilip Kota wrote:
> This patch series adds Intel ComboPhy driver, respective yaml schemas
> 
> Changes on v8:
>   As per PHY Maintainer's request add description in comments for doing
>   register access through register map framework.
> 
> Changes on v7:
>   As per System control driver maintainer's inputs remove
>     fwnode_to_regmap() definition and use device_node_get_regmap()

Can you fix this warning and resend the patch?
drivers/phy/intel/phy-intel-combo.c:229:6: warning: ‘cb_mode’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
  ret = regmap_write(cbphy->hsiocfg, REG_COMBO_MODE(cbphy->bid), cb_mode);
  ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/intel/phy-intel-combo.c:204:24: note: ‘cb_mode’ was declared here
  enum intel_combo_mode cb_mode;
                        ^~~~~~~

Thanks
Kishon
>     
> Changes on v6:
>   Rebase patches on the latest maintainer's branch
>   https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git/?h=phy-for-5.7
> Dilip Kota (3):
>   dt-bindings: phy: Add PHY_TYPE_XPCS definition
>   dt-bindings: phy: Add YAML schemas for Intel ComboPhy
>   phy: intel: Add driver support for ComboPhy
> 
>  .../devicetree/bindings/phy/intel,combo-phy.yaml   | 101 ++++
>  drivers/phy/intel/Kconfig                          |  14 +
>  drivers/phy/intel/Makefile                         |   1 +
>  drivers/phy/intel/phy-intel-combo.c                | 632 +++++++++++++++++++++
>  include/dt-bindings/phy/phy.h                      |   1 +
>  5 files changed, 749 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/intel,combo-phy.yaml
>  create mode 100644 drivers/phy/intel/phy-intel-combo.c
>