linux-kernel - Re: [PATCH 28/28] dt-bindings: usb: Convert ehci-mv to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+oQSk=xGBiQ73SyGggo=gBOmH6xvTv1QBAUfbnt42E0A@mail.gmail.com>
Date:   Mon, 18 May 2020 09:20:13 -0600
From:   Rob Herring <robh@...nel.org>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <maz@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Brown <broonie@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux I2C <linux-i2c@...r.kernel.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@...r.kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        Linux USB List <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 28/28] dt-bindings: usb: Convert ehci-mv to json-schema

On Sun, May 17, 2020 at 1:34 PM Lubomir Rintel <lkundrak@...sk> wrote:
>
> On Fri, Mar 27, 2020 at 01:55:20PM -0600, Rob Herring wrote:
> > On Tue, Mar 17, 2020 at 10:39:22AM +0100, Lubomir Rintel wrote:
> > > A straightforward conversion of the ehci-mv binding to DT schema format
> > > using json-schema.
> > >
> > > Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> > > ---
> > >  .../devicetree/bindings/usb/ehci-mv.txt       | 23 -------
> > >  .../bindings/usb/marvell,pxau2o-ehci.yaml     | 60 +++++++++++++++++++
> > >  2 files changed, 60 insertions(+), 23 deletions(-)
> > >  delete mode 100644 Documentation/devicetree/bindings/usb/ehci-mv.txt
> > >  create mode 100644 Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/ehci-mv.txt b/Documentation/devicetree/bindings/usb/ehci-mv.txt
> > > deleted file mode 100644
> > > index 335589895763e..0000000000000
> > > --- a/Documentation/devicetree/bindings/usb/ehci-mv.txt
> > > +++ /dev/null
> > > @@ -1,23 +0,0 @@
> > > -* Marvell PXA/MMP EHCI controller.
> > > -
> > > -Required properties:
> > > -
> > > -- compatible: must be "marvell,pxau2o-ehci"
> > > -- reg: physical base addresses of the controller and length of memory mapped region
> > > -- interrupts: one EHCI controller interrupt should be described here
> > > -- clocks: phandle list of usb clocks
> > > -- clock-names: should be "USBCLK"
> > > -- phys: phandle for the PHY device
> > > -- phy-names: should be "usb"
> > > -
> > > -Example:
> > > -
> > > -   ehci0: usb-ehci@...08000 {
> > > -           compatible = "marvell,pxau2o-ehci";
> > > -           reg = <0xd4208000 0x200>;
> > > -           interrupts = <44>;
> > > -           clocks = <&soc_clocks MMP2_CLK_USB>;
> > > -           clock-names = "USBCLK";
> > > -           phys = <&usb_otg_phy>;
> > > -           phy-names = "usb";
> > > -   };
> > > diff --git a/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml b/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
> > > new file mode 100644
> > > index 0000000000000..189025ef1e92e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
> > > @@ -0,0 +1,60 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> >
> > Same license comment.
>
> I wrote that binding document and chose that license.

Okay, but please make it GPL-2.0-only instead of or-later. If everyone
was attentive to licensing picking their own variations would be fine,
but they aren't and just copy-n-paste. So there's 2 choices
GPL-2.0-only (for converted bindings) or (GPL-2.0-only OR
BSD-2-Clause) for new or re-licensed bindings.

Rob