linux-kernel - Re: [PATCH net-next] hinic: add support to set and get pause param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a340973-ad63-b3e4-a212-4eb9dbe2ee3f@huawei.com>
Date:   Mon, 18 May 2020 08:51:00 +0800
From:   "luobin (L)" <luobin9@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <luoxianjun@...wei.com>, <yin.yinshi@...wei.com>,
        <cloud.wangxiaoyun@...wei.com>
Subject: Re: [PATCH net-next] hinic: add support to set and get pause param

Will fix. Thanks.

On 2020/5/17 4:25, David Miller wrote:
> From: Luo bin <luobin9@...wei.com>
> Date: Sat, 16 May 2020 02:00:30 +0000
>
>> add support to set pause param with ethtool -A and get pause
>> param with ethtool -a. Also remove set_link_ksettings ops for VF.
>>
>> Signed-off-by: Luo bin <luobin9@...wei.com>
> Why are you using a semaphore and not a plain mutex.
>
> Semaphores should be used as an absolute last resort, and only
> after trying vigorously to use other locking primitives.
> .