linux-kernel - Re: [PATCH] net: bmac: Fix read of MAC address from ROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200519.120351.1307026516427954350.davem@davemloft.net>
Date:   Tue, 19 May 2020 12:03:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jk@...abs.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        benh@...nel.crashing.org, paulus@...ba.org,
        fthain@...egraphics.com.au, userm57@...oo.com
Subject: Re: [PATCH] net: bmac: Fix read of MAC address from ROM

From: Jeremy Kerr <jk@...abs.org>
Date: Tue, 19 May 2020 09:05:58 +0800

> In bmac_get_station_address, We're reading two bytes at a time from ROM,
> but we do that six times, resulting in 12 bytes of read & writes. This
> means we will write off the end of the six-byte destination buffer.
> 
> This change fixes the for-loop to only read/write six bytes.
> 
> Based on a proposed fix from Finn Thain <fthain@...egraphics.com.au>.
> 
> Signed-off-by: Jeremy Kerr <jk@...abs.org>
> Reported-by: Stan Johnson <userm57@...oo.com>
> Tested-by: Stan Johnson <userm57@...oo.com>
> Reported-by: Finn Thain <fthain@...egraphics.com.au>

Applied, thanks.