linux-kernel - Re: [PATCH 04/10] dt-bindings: spi: Add bindings for spi-dw-mchp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200519114739.GD24801@soft-dev15.microsemi.net>
Date:   Tue, 19 May 2020 13:47:39 +0200
From:   Lars Povlsen <lars.povlsen@...rochip.com>
To:     Mark Brown <broonie@...nel.org>
CC:     SoC Team <soc@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        "Microchip Linux Driver Support" <UNGLinuxDriver@...rochip.com>,
        <linux-spi@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        Serge Semin <fancer.lancer@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@...el.com>,
        Lars Povlsen <lars.povlsen@...rochip.com>
Subject: Re: [PATCH 04/10] dt-bindings: spi: Add bindings for spi-dw-mchp

On 13/05/20 15:52, Mark Brown wrote:
> Date: Wed, 13 May 2020 15:52:13 +0100
> From: Mark Brown <broonie@...nel.org>
> To: Lars Povlsen <lars.povlsen@...rochip.com>
> Cc: SoC Team <soc@...nel.org>, Rob Herring <robh+dt@...nel.org>, Microchip
>  Linux Driver Support <UNGLinuxDriver@...rochip.com>,
>  linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
>  linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
>  Alexandre Belloni <alexandre.belloni@...tlin.com>, Serge Semin
>  <Sergey.Semin@...kalelectronics.ru>, Serge Semin
>  <fancer.lancer@...il.com>, Andy Shevchenko
>  <andriy.shevchenko@...ux.intel.com>, Wan Ahmad Zainie
>  <wan.ahmad.zainie.wan.mohamad@...el.com>
> Subject: Re: [PATCH 04/10] dt-bindings: spi: Add bindings for spi-dw-mchp
> User-Agent: Mutt/1.10.1 (2018-07-13)
> 
> On Wed, May 13, 2020 at 04:00:25PM +0200, Lars Povlsen wrote:
> > This add DT bindings for the Microsemi/Microchip SPI controller used
> > in various SoC's. It describes the "mscc,ocelot-spi" and
> > "mscc,jaguar2-spi" bindings.
> 
> > Reviewed-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> > Signed-off-by: Lars Povlsen <lars.povlsen@...rochip.com>
> > ---
> >  .../bindings/spi/mscc,ocelot-spi.yaml         | 60 +++++++++++++++++++
> >  .../bindings/spi/snps,dw-apb-ssi.txt          |  7 +--
> 
> That's not what this change does.  It is removing the existing binding
> for Ocelot and Jaguar2 from the free format binding documentation and
> adds some entirely separate YAML bindings for them.  This conflicts with
> competing YAML conversions that both Serge Semin and Wan Ahmad Zainie
> (CCed) have in flight at the minute.  It also doesn't strike me as a
> good idea to fork the bindings, what's the motivation for doing that?

The reason for doing this was due to the fact that I felt adding
Sparx5 support only cluttered the original driver even more.

And since I was adding a new driver, I needed to add bindings for it -
and (re)move the old ones.

I have become aware of Serge and Wan Ahmad's work, and will work out
something on top of that.