linux-kernel - Re: [PATCH 04/10] dt-bindings: spi: Add bindings for spi-dw-mchp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200519121001.GA26056@soft-dev15.microsemi.net>
Date:   Tue, 19 May 2020 14:10:01 +0200
From:   Lars Povlsen <lars.povlsen@...rochip.com>
To:     Mark Brown <broonie@...nel.org>
CC:     SoC Team <soc@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        "Microchip Linux Driver Support" <UNGLinuxDriver@...rochip.com>,
        <linux-spi@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        Serge Semin <fancer.lancer@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@...el.com>,
        Lars Povlsen <lars.povlsen@...rochip.com>
Subject: Re: [PATCH 04/10] dt-bindings: spi: Add bindings for spi-dw-mchp

On 19/05/20 12:58, Mark Brown wrote:
> Date: Tue, 19 May 2020 12:58:29 +0100
> From: Mark Brown <broonie@...nel.org>
> To: Lars Povlsen <lars.povlsen@...rochip.com>
> Cc: SoC Team <soc@...nel.org>, Rob Herring <robh+dt@...nel.org>, Microchip
>  Linux Driver Support <UNGLinuxDriver@...rochip.com>,
>  linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
>  linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
>  Alexandre Belloni <alexandre.belloni@...tlin.com>, Serge Semin
>  <Sergey.Semin@...kalelectronics.ru>, Serge Semin
>  <fancer.lancer@...il.com>, Andy Shevchenko
>  <andriy.shevchenko@...ux.intel.com>, Wan Ahmad Zainie
>  <wan.ahmad.zainie.wan.mohamad@...el.com>
> Subject: Re: [PATCH 04/10] dt-bindings: spi: Add bindings for spi-dw-mchp
> User-Agent: Mutt/1.10.1 (2018-07-13)
> 
> On Tue, May 19, 2020 at 01:47:39PM +0200, Lars Povlsen wrote:
> > On 13/05/20 15:52, Mark Brown wrote:
> 
> > > On Wed, May 13, 2020 at 04:00:25PM +0200, Lars Povlsen wrote:
> > > > This add DT bindings for the Microsemi/Microchip SPI controller used
> > > > in various SoC's. It describes the "mscc,ocelot-spi" and
> > > > "mscc,jaguar2-spi" bindings.
> 
> > > That's not what this change does.  It is removing the existing binding
> > > for Ocelot and Jaguar2 from the free format binding documentation and
> 
> > The reason for doing this was due to the fact that I felt adding
> > Sparx5 support only cluttered the original driver even more.
> 
> That's not the issue I'm pointing out there.  The issue is that your
> changelog claims that the change does one thing and the change itself
> does something substantially different.

Ok, got it. I'll reword the changelog to be more precise.

Thanks again,

---Lars