linux-kernel - Re: [PATCH] RDMA/rtrs: client: Fix function return on success

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMGffE=15s=GsO02iHL0qhBAaGx8OCBMUeR--GRWD6g41pnfyw@mail.gmail.com>
Date:   Tue, 19 May 2020 18:21:35 +0200
From:   Jinpu Wang <jinpu.wang@...ud.ionos.com>
To:     Bart Van Assche <bvanassche@....org>
Cc:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Danil Kipnis <danil.kipnis@...ud.ionos.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: Re: [PATCH] RDMA/rtrs: client: Fix function return on success

On Tue, May 19, 2020 at 6:16 PM Bart Van Assche <bvanassche@....org> wrote:
>
> On 2020-05-19 09:13, Gustavo A. R. Silva wrote:
> > The function should return 0 on success, instead of err.
> >
> > Addresses-Coverity-ID: 1493753 ("Identical code for different branches")
> > Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality")
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> > ---
> >  drivers/infiniband/ulp/rtrs/rtrs-clt.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> > index 468fdd0d8713c..465515e46bb1a 100644
> > --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> > +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> > @@ -1594,7 +1594,8 @@ static int create_con_cq_qp(struct rtrs_clt_con *con)
> >
> >       if (err)
> >               return err;
> > -     return err;
> > +
> > +     return 0;
> >  }
>
> Why to keep the if-statement? Has the following been considered?
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> index 8dfa56dc32bc..a7f5d55f8542 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> @@ -1587,8 +1587,6 @@ static int create_con_cq_qp(struct rtrs_clt_con *con)
>          * since destroy_con_cq_qp() must be called.
>          */
>
> -       if (err)
> -               return err;
>         return err;
>  }
>
> Thanks,
>
> Bart.

This one seems better, thanks Bart and Gustavo, Gustavo, would you
like to send a v2 patch as Bart suggested?

Thanks,