linux-kernel - Re: [PATCH 2/3] selftests: vdso: Use a header file to prototype parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 May 2020 18:42:44 +0100
From:   Mark Brown <broonie@...nel.org>
To:     shuah <shuah@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 2/3] selftests: vdso: Use a header file to prototype
 parse_vdso API

On Tue, May 19, 2020 at 11:29:10AM -0600, shuah wrote:
> On 5/5/20 11:47 AM, Mark Brown wrote:

> > - * These are the prototypes:
> > - */
> > -extern void vdso_init_from_auxv(void *auxv);
> > -extern void vdso_init_from_sysinfo_ehdr(uintptr_t base);
> > -extern void *vdso_sym(const char *version, const char *name);

> > + * These are the prototypes:
> > + */
> > +extern void *vdso_sym(const char *version, const char *name);
> > +extern void vdso_init_from_sysinfo_ehdr(uintptr_t base);
> > +extern void vdso_init_from_auxv(void *auxv);

> You don't need extern here - this should be in scope?

This is just code motion of existing code which has the externs.
There's no cases where you *need* the extern, it's just syntactic sugar.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)