linux-kernel - Re: [PATCH] sh: include linux/time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0+RWNUroSAtdVazxMV=o+FYpTX9Wvkbr5gODh4=zODkQ@mail.gmail.com>
Date:   Wed, 20 May 2020 16:46:17 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        "David S. Miller" <davem@...emloft.net>,
        John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
        Linux-sh list <linux-sh@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sh: include linux/time_types.h for sockios

On Wed, May 20, 2020 at 1:47 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> On Wed, May 20, 2020 at 10:32 AM Arnd Bergmann <arnd@...db.de> wrote:
> > On Wed, May 20, 2020 at 3:10 AM Andrew Morton <akpm@...ux-foundation.org> wrote:
> > > On Tue, 19 May 2020 15:13:13 +0200 Arnd Bergmann <arnd@...db.de> wrote:
> > > > Using the socket ioctls on arch/sh (and only there) causes build
> > > > time problems when __kernel_old_timeval/__kernel_old_timespec are
> > > > not already visible to the compiler.
> > > >
> > > > Add an explict include line for the header that defines these
> > > > structures.
> > >
> > > I can grab this.
> >
> > Thanks!
> >
> > > > Reported-by: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
> > > > Tested-by: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
> > > > Fixes: 8c709f9a0693 ("y2038: sh: remove timeval/timespec usage from headers")
> > > > Fixes: 0768e17073dc ("net: socket: implement 64-bit timestamps")
> > >
> > > cc:stable?
> >
> > Yes, I missed that.
>
> Doesn't matter, the stable bots will pick it up anyway, based on the Fixes tag.

I normally prefer to be explicit, as some bug fixes may address
something that has been caused by an earlier commit, but should not
be backported for some reason.

      Arnd