linux-kernel - RE: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 May 2020 15:33:27 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Dan Williams' <dan.j.williams@...el.com>,
        Michael Ellerman <mpe@...erman.id.au>
CC:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, "X86 ML" <x86@...nel.org>,
        stable <stable@...r.kernel.org>, Borislav Petkov <bp@...en8.de>,
        Tony Luck <tony.luck@...el.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Paul Mackerras <paulus@...ba.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Mikulas Patocka <mpatocka@...hat.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        "Linus Torvalds" <torvalds@...ux-foundation.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-nvdimm <linux-nvdimm@...ts.01.org>
Subject: RE: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to
 copy_mc_to_{user, kernel}()

From: Dan Williams
> Sent: 20 May 2020 16:26
...
> > > +#ifdef CONFIG_ARCH_HAS_COPY_MC
> > > +extern unsigned long __must_check
> >
> > We try not to add extern in headers anymore.
> 
> Ok, I was doing the copy-pasta dance, but I'll remove this.

It is data not code, it needs the extern to not be 'common'.
OTOH what is a global variable being used for?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)