linux-kernel - Re: [PATCH v2] i2c: cadence: Add error handling for a platform_get_irq() call in cdns_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <d1e26bf4-9317-b28a-ed87-8e1eddbca99e@web.de>
Date:   Wed, 20 May 2020 17:34:23 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Dejin Zheng <zhengdejin5@...il.com>, linux-i2c@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Harini Katakam <harinik@...inx.com>,
        Michal Simek <michal.simek@...inx.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        Wolfram Sang <wsa@...-dreams.de>
Subject: Re: [PATCH v2] i2c: cadence: Add error handling for a
 platform_get_irq() call in cdns_i2c_probe()

> The driver initialization should be end immediately after found
> the platform_get_irq() function return an error.

I recommend to improve also this change description.
How do you think about a wording variant like the following?

   Return an error code after a call of the function “platform_get_irq” failed.


Regards,
Markus