linux-kernel - Re: [PATCHv3 2/5] Input: EXC3000: switch to i2c's probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d0d7e26-379f-5918-451f-b4445a652272@collabora.com>
Date:   Wed, 20 May 2020 18:50:09 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Ahmet Inan <inan@...tec.de>,
        Martin Fuzzey <martin.fuzzey@...wbird.group>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCHv3 2/5] Input: EXC3000: switch to i2c's probe_new API

Hi Sebastian,

On 20/5/20 17:39, Sebastian Reichel wrote:
> Switch to the "new" I2C probe API.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

> ---
>  drivers/input/touchscreen/exc3000.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/exc3000.c b/drivers/input/touchscreen/exc3000.c
> index e007e2e8f626..555a14305cd4 100644
> --- a/drivers/input/touchscreen/exc3000.c
> +++ b/drivers/input/touchscreen/exc3000.c
> @@ -145,8 +145,7 @@ static irqreturn_t exc3000_interrupt(int irq, void *dev_id)
>  	return IRQ_HANDLED;
>  }
>  
> -static int exc3000_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int exc3000_probe(struct i2c_client *client)
>  {
>  	struct exc3000_data *data;
>  	struct input_dev *input;
> @@ -210,7 +209,7 @@ static struct i2c_driver exc3000_driver = {
>  		.of_match_table = of_match_ptr(exc3000_of_match),
>  	},
>  	.id_table	= exc3000_id,
> -	.probe		= exc3000_probe,
> +	.probe_new	= exc3000_probe,
>  };
>  
>  module_i2c_driver(exc3000_driver);
>