linux-kernel - Re: [PATCH] rds: fix crash in rds_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d848c10e-1d04-3669-0d0f-5b53505686b1@oracle.com>
Date:   Wed, 20 May 2020 12:43:39 -0700
From:   santosh.shilimkar@...cle.com
To:     John Hubbard <jhubbard@...dia.com>,
        syzbot+118ac0af4ac7f785a45b@...kaller.appspotmail.com
Cc:     akpm@...ux-foundation.org, davem@...emloft.net, kuba@...nel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        rds-devel@....oracle.com, syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] rds: fix crash in rds_info_getsockopt()

On 5/20/20 12:41 PM, John Hubbard wrote:
> The conversion to pin_user_pages() had a bug: it overlooked
> the case of allocation of pages failing. Fix that by restoring
> an equivalent check.
> 
> Reported-by: syzbot+118ac0af4ac7f785a45b@...kaller.appspotmail.com
> Fixes: dbfe7d74376e ("rds: convert get_user_pages() --> pin_user_pages()")
> 
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: netdev@...r.kernel.org
> Cc: linux-rdma@...r.kernel.org
> Cc: rds-devel@....oracle.com
> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> ---
Thanks John !!

Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>