linux-kernel - Re: [PATCH v6 01/11] PCI: designware-ep: Add multiple PFs support for DWC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200520203239.GA503864@bogus>
Date:   Wed, 20 May 2020 14:32:39 -0600
From:   Rob Herring <robh@...nel.org>
To:     Xiaowei Bao <xiaowei.bao@....com>
Cc:     roy.zang@....com, robh+dt@...nel.org, linux-kernel@...r.kernel.org,
        Zhiqiang.Hou@....com, jingoohan1@...il.com,
        devicetree@...r.kernel.org, gustavo.pimentel@...opsys.com,
        Minghuan.Lian@....com, mingkai.hu@....com,
        linux-arm-kernel@...ts.infradead.org, leoyang.li@....com,
        shawnguo@...nel.org, andrew.murray@....com,
        linux-pci@...r.kernel.org, bhelgaas@...gle.com,
        lorenzo.pieralisi@....com, kishon@...com,
        linuxppc-dev@...ts.ozlabs.org, amurray@...goodpenguin.co.uk
Subject: Re: [PATCH v6 01/11] PCI: designware-ep: Add multiple PFs support
 for DWC

On Sat, 14 Mar 2020 11:30:28 +0800, Xiaowei Bao wrote:
> Add multiple PFs support for DWC, due to different PF have different
> config space, we use func_conf_select callback function to access
> the different PF's config space, the different chip company need to
> implement this callback function when use the DWC IP core and intend
> to support multiple PFs feature.
> 
> Signed-off-by: Xiaowei Bao <xiaowei.bao@....com>
> Acked-by: Gustavo Pimentel <gustavo.pimentel@...opsys.com>
> ---
> v2:
>  - Remove duplicate redundant code.
>  - Reimplement the PF config space access way.
> v3:
>  - Integrate duplicate code for func_select.
>  - Move PCIE_ATU_FUNC_NUM(pf) (pf << 20) to ((pf) << 20).
>  - Add the comments for func_conf_select function.
> v4:
>  - Correct the commit message.
> v5:
>  - No change.
> v6:
>  - No change.
> 
>  drivers/pci/controller/dwc/pcie-designware-ep.c | 123 ++++++++++++++++--------
>  drivers/pci/controller/dwc/pcie-designware.c    |  59 ++++++++----
>  drivers/pci/controller/dwc/pcie-designware.h    |  18 +++-
>  3 files changed, 142 insertions(+), 58 deletions(-)
> 

Reviewed-by: Rob Herring <robh@...nel.org>