linux-kernel - Re: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9da499dc-2450-5f4e-e108-9a8565a10a77@ti.com>
Date:   Wed, 20 May 2020 10:08:54 +0300
From:   Peter Ujfalusi <peter.ujfalusi@...com>
To:     Jason Yan <yanaijie@...wei.com>,
        Russell King - ARM Linux admin <linux@...linux.org.uk>
CC:     <tony@...mide.com>, <linux-omap@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in
 configure_dma_errata()



On 06/05/2020 11.43, Jason Yan wrote:
> 
> 
> 在 2020/5/6 16:29, Russell King - ARM Linux admin 写道:
>> On Wed, May 06, 2020 at 02:19:00PM +0800, Jason Yan wrote:
>>> Fix the following coccicheck warning:
>>>
>>> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return
>>> "0" on line 161
>>
>> NAK.  Look closer at what the code is doing, thanks.
>>
>> This warning is basically incorrect.
>>
> 
> OK, the macro SET_DMA_ERRATA is using this variable.

How can a patch from you can be trusted if you did not even try to
compile-test?
Please try to _test_ your changes before sending, or add a disclaimer
that it might not even compile.

Thanks,
- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Download attachment "pEpkey.asc" of type "application/pgp-keys" (1754 bytes)