linux-kernel - Re: [PATCH] of: drop a reference on error in __of_attach_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877dx69az4.fsf@mpe.ellerman.id.au>
Date:   Wed, 20 May 2020 20:06:39 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] of: drop a reference on error in __of_attach_node_sysfs()

Dan Carpenter <dan.carpenter@...cle.com> writes:
> We add a new of_node_get() to this function, but we should drop the
> reference if kobject_add().
                            ^
                            fails?
>
> Fixes: 5b2c2f5a0ea3 ("of: overlay: add missing of_node_get() in __of_attach_node_sysfs")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> From static analysis.  Maybe we should just call of_node_get() right
> before we return 0?

Yeah that would be simpler and equally correct AFAICS.

cheers

> diff --git a/drivers/of/kobj.c b/drivers/of/kobj.c
> index c72eef988041..a90dc4b3b060 100644
> --- a/drivers/of/kobj.c
> +++ b/drivers/of/kobj.c
> @@ -138,8 +138,10 @@ int __of_attach_node_sysfs(struct device_node *np)
>  
>  	rc = kobject_add(&np->kobj, parent, "%s", name);
>  	kfree(name);
> -	if (rc)
> +	if (rc) {
> +		of_node_put(np);
>  		return rc;
> +	}
>  
>  	for_each_property_of_node(np, pp)
>  		__of_add_property_sysfs(np, pp);
> -- 
> 2.26.2