linux-kernel - Re: [PATCH] powercap: remove unused local MSR define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200520115358.GR1634618@smile.fi.intel.com>
Date:   Wed, 20 May 2020 14:53:58 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Sumeet Pawnikar <sumeet.r.pawnikar@...el.com>
Cc:     rui.zhang@...el.com, rjw@...ysocki.net, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, srinivas.pandruvada@...ux.intel.com
Subject: Re: [PATCH] powercap: remove unused local MSR define

On Wed, May 20, 2020 at 05:06:18PM +0530, Sumeet Pawnikar wrote:
> From: "Pawnikar, Sumeet" <sumeet.r.pawnikar@...el.com>
> 
> Remove unused PLATFORM_POWER_LIMIT MSR local definition from file
> intel_rapl_common.c. This was missed while splitting old RAPL code
> intel_rapl.c file into two new files intel_rapl_msr.c and
> intel_rapl_common.c as per the commit 3382388d7148
> ("intel_rapl: abstract RAPL common code"). Currently, this #define
> entry is being used only in intel_rapl_msr.c file and local definition
> present in this file.

> Signed-off-by: Pawnikar, Sumeet <sumeet.r.pawnikar@...el.com>

Reorganize this to avoid comma (this also should make From: gone in the top of
this message). After addressing,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>

> ---
>  drivers/powercap/intel_rapl_common.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
> index eb328655bc01..5527a7c76309 100644
> --- a/drivers/powercap/intel_rapl_common.c
> +++ b/drivers/powercap/intel_rapl_common.c
> @@ -26,9 +26,6 @@
>  #include <asm/cpu_device_id.h>
>  #include <asm/intel-family.h>
>  
> -/* Local defines */
> -#define MSR_PLATFORM_POWER_LIMIT	0x0000065C
> -
>  /* bitmasks for RAPL MSRs, used by primitive access functions */
>  #define ENERGY_STATUS_MASK      0xffffffff
>  
> -- 
> 1.7.9.5
> 

-- 
With Best Regards,
Andy Shevchenko