linux-kernel - Re: [PATCH v4 0/4] cleaning up the sysctls table (hung

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200520130802.GW11244@42.do-not-panic.com>
Date:   Wed, 20 May 2020 13:08:03 +0000
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Xiaoming Ni <nixiaoming@...wei.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, keescook@...omium.org,
        yzaikin@...gle.com, adobriyan@...il.com, mingo@...nel.org,
        gpiccoli@...onical.com, rdna@...com, patrick.bellasi@....com,
        sfr@...b.auug.org.au, mhocko@...e.com,
        penguin-kernel@...ove.sakura.ne.jp, vbabka@...e.cz,
        tglx@...utronix.de, peterz@...radead.org,
        Jisheng.Zhang@...aptics.com, khlebnikov@...dex-team.ru,
        bigeasy@...utronix.de, pmladek@...e.com,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        wangle6@...wei.com, alex.huangjianhui@...wei.com
Subject: Re: [PATCH v4 0/4] cleaning up the sysctls table (hung_task watchdog)

On Wed, May 20, 2020 at 12:02:26PM +0800, Xiaoming Ni wrote:
> On 2020/5/20 11:31, Andrew Morton wrote:
> > On Tue, 19 May 2020 11:31:07 +0800 Xiaoming Ni <nixiaoming@...wei.com> wrote:
> > 
> > > Kernel/sysctl.c
> > 
> > eek!
> > 
> > > 
> > >   fs/proc/proc_sysctl.c        |   2 +-
> > >   include/linux/sched/sysctl.h |  14 +--
> > >   include/linux/sysctl.h       |  13 ++-
> > >   kernel/hung_task.c           |  77 +++++++++++++++-
> > >   kernel/sysctl.c              | 214 +++++++------------------------------------
> > >   kernel/watchdog.c            | 101 ++++++++++++++++++++
> > >   6 files changed, 224 insertions(+), 197 deletions(-)
> > 
> > Here's what we presently have happening in linux-next's kernel/sysctl.c:
> > 
> >   sysctl.c | 3109 ++++++++++++++++++++++++++++++---------------------------------
> >   1 file changed, 1521 insertions(+), 1588 deletions(-)
> > 
> > 
> > So this is not a good time for your patch!
> > 
> > Can I suggest that you set the idea aside and take a look after 5.8-rc1
> > is released?
> > 
> 
> ok, I will make v5 patch based on 5.8-rc1 after 5.8-rc1 is released,
> And add more sysctl table cleanup.

Xiaoming, I'll coordinate with you on this offline as I have the fs
kernel/sysctl.c stuff out of the way as well.

  Luis